| Not | [iDempiereDaily] jenkins build #90 started http://ci.idempiere.org/job/iDempiereDaily/90/ | 02:08 |
|---|---|---|
| Not | [iDempiereDaily] jenkins build #90 completed: success http://ci.idempiere.org/job/iDempiereDaily/90/ | 02:34 |
| *** a42niem <a42niem!~niem@p578b7daf.dip0.t-ipconnect.de> has joined #idempiere | 05:21 | |
| *** nmicoud <nmicoud!~Nicolas@2a01:e34:eeb6:cb10:58b6:133d:6ef8:10e2> has joined #idempiere | 05:50 | |
| Not | [IDEMPIERE] hengsin created IDEMPIERE-4047 Minor trx fix for GridTabCSVImporter | 07:06 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4047 | 07:06 |
| Not | [iDempiere] 1 commit to default [+0/-0/±2] https://bitbucket.org/idempiere/idempiere/commits/ | 07:08 |
| Not | [iDempiere] hengsin 6a6caab - IDEMPIERE-4047 Minor trx fix for GridTabCSVImporter | 07:08 |
| Not | [IDEMPIERE] hengsin updated IDEMPIERE-4047 status set to "Resolved" -Fix Version set to "6.2z" -resolution set to "Fixed" | 07:08 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4047 | 07:08 |
| Not | [iDempiere] jenkins build #178 started http://ci.idempiere.org/job/iDempiere/178/ | 07:21 |
| Not | [iDempiere] jenkins build #178 completed: failure http://ci.idempiere.org/job/iDempiere/178/ | 07:25 |
| *** CarlosRuiz <CarlosRuiz!~CarlosRui@ip-95-223-106-12.hsi16.unitymediagroup.de> has joined #idempiere | 09:13 | |
| nmicoud | Hello CarlosRuiz, wdyt of integrating SmartFinReport plugin6.2 in the trunk (see https://groups.google.com/forum/#!topic/idempiere/BhGMIaI8ZQo) ? | 11:39 |
| CarlosRuiz | we did a review recently | 12:05 |
| CarlosRuiz | the way it was developed make it not core friendly | 12:05 |
| nmicoud | I agree, it need to be rethinked from the start | 12:06 |
| nmicoud | idea would be to take all enhancements and add them in the "good" way | 12:06 |
| CarlosRuiz | we took a look to this plugin plus some add-ons for finreport that were contributed from adaxa to adempiere | 12:06 |
| CarlosRuiz | that was poorly integrated to adempiere | 12:07 |
| CarlosRuiz | the smartfinreport is integrated but is doesn't work unless you change some sysconfig I think - and in that case some other things may be broken probably | 12:07 |
| CarlosRuiz | and some of the contributions from adaxa did the same things that some of the things from smartfinreport | 12:07 |
| CarlosRuiz | and both added the same column with different name | 12:08 |
| CarlosRuiz | the changes from adaxa were very clear and integratable - Steven told me Deepak will work on integrating that to iDempiere - but I think maybe he hasn't found the time | 12:09 |
| CarlosRuiz | for the smartfinreport - after the review we decided to keep it as plugin | 12:10 |
| nmicoud | Ok, so if I need some enhancements from smf, i integrate them in my own version, right ? no need to find a clean way to make it part of the trunk ? | 12:11 |
| CarlosRuiz | if you find a way trunk-friendly - all those add-ons are great | 12:12 |
| nmicoud | So maybe, add them one by one ? | 12:12 |
| CarlosRuiz | I would try to start with the adaxa pieces first - have you seen that? | 12:12 |
| nmicoud | that's not urgent for me as the customer do all those calculations outside of iDempiere, but that would be better if he can do it directly in | 12:13 |
| nmicoud | no, never head of | 12:13 |
| CarlosRuiz | last time I tried a finreport on adempiere - it showed nothing - so don't know really if is working or was wrongly integrated | 12:13 |
| nmicoud | or both :D | 12:13 |
| nmicoud | last time I played with FinReport, it was on Compiere times (10 years ago). And I rediscover it some months ago, and that's a very powerful tool. But some tools are missing | 12:14 |
| CarlosRuiz | from what I see is a cube viewwer | 12:15 |
| CarlosRuiz | cube viewer | 12:15 |
| nmicoud | Is there a repository where I can find adaxa enhancements ? | 12:15 |
| CarlosRuiz | let me try to find my notes on the review | 12:16 |
| nmicoud | no need to hurry | 12:16 |
| nmicoud | when you have time | 12:17 |
| CarlosRuiz | ah yes - first complication we found the manual is gone | 12:17 |
| CarlosRuiz | http://smartjsp.com/smartreport/AdvancedFinancialReportingForAdempiereV1.pdf | 12:17 |
| nmicoud | Peter write a new one (which seems to match with 'his' plugin) | 12:20 |
| CarlosRuiz | these notes are from Diego: | 12:20 |
| CarlosRuiz | "the plugin does not reuse the existing code in core for Reports and PDF/Excel creation, and instead, creates code that rewrites existing logic but make it in a way that is won't work for any other piece of the core, as it has a dependency on T_Report, so basically it duplicates code with some differences, one class for financial report another one for every other report in the system. In my opinion, this is a very bad | 12:20 |
| CarlosRuiz | approach and would be expensive to maintain and scalate in the future." | 12:20 |
| CarlosRuiz | which Peter? | 12:20 |
| nmicoud | Peter Sheptenko (or something like that) | 12:20 |
| CarlosRuiz | ah ok | 12:20 |
| CarlosRuiz | and my note after the review: | 12:21 |
| CarlosRuiz | "I wonder if would be easier to create some sort of styling and pass that information to jasper and let jasper do the work. I think that option maybe is easier and more extensible to implement" | 12:21 |
| nmicoud | When I got the need to have percentage calcultation, he offers to publish the plugin he made for a previous version. And I offer to integrate it in the trunk (if is ok for you) | 12:22 |
| CarlosRuiz | yes - percentage calculation is simple and doesn't require any PDF change | 12:22 |
| nmicoud | That's why maybe the easier way to integrate those enhancements is : 1. list them ; 2. add them one by one | 12:23 |
| nmicoud | I got to go outside for a while, I should be back around 15 | 12:29 |
| CarlosRuiz | I can't find the adaxa stuff | 12:29 |
| CarlosRuiz | will note it here if I find it | 12:29 |
| nmicoud | ok, thanks | 12:29 |
| CarlosRuiz | we reviewed the percentage stuff - it as modifying FinReport - not the PDF side - so is integrable | 12:31 |
| CarlosRuiz | but it uses Float for the calculations - that's a bad practice - it must be changed to BigDecimal | 12:31 |
| CarlosRuiz | couldn't find the adaxa changes | 12:40 |
| Not | [IDEMPIERE] hengsin created IDEMPIERE-4048 Fix maven build error | 12:56 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4048 | 12:56 |
| Not | [IDEMPIERE] hengsin updated IDEMPIERE-4048 description set to "mvn verify -U error out on default branch [https://groups.google.com/d/topic/idempiere/6VHtkPh9Lo8/discussion|https://groups.google.com/d/topic/idempiere/6VHtkPh9Lo8/discussion]" | 12:59 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4048 | 12:59 |
| Not | [IDEMPIERE] Heng Sin Low updated IDEMPIERE-4048 assignee set to "Heng Sin Low" | 13:00 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4048 | 13:00 |
| Not | [iDempiere] 1 commit to default [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ | 13:04 |
| Not | [iDempiere] hengsin bd8f37d - IDEMPIERE-4048 Fix maven build error. Integrate solution from Ken Longnan | 13:04 |
| Not | [IDEMPIERE] Heng Sin Low updated IDEMPIERE-4048 status set to "Resolved" -Fix Version set to "6.2z" -resolution set to "Fixed" | 13:05 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4048 | 13:05 |
| nmicoud | ok, i'll make a patch for the percentage part (using BigDecimal). | 13:10 |
| Not | [iDempiere] jenkins build #179 started http://ci.idempiere.org/job/iDempiere/179/ | 13:21 |
| Not | [iDempiere] jenkins build #179 completed: success http://ci.idempiere.org/job/iDempiere/179/ | 13:29 |
| *** nmicoud <nmicoud!~Nicolas@2a01:e34:eeb6:cb10:58b6:133d:6ef8:10e2> has quit IRC | 15:16 | |
| *** CarlosRuiz <CarlosRuiz!~CarlosRui@ip-95-223-106-12.hsi16.unitymediagroup.de> has quit IRC | 15:42 | |
| *** CarlosRuiz <CarlosRuiz!~CarlosRui@ip-95-223-106-12.hsi16.unitymediagroup.de> has joined #idempiere | 18:10 | |
| *** CarlosRuiz <CarlosRuiz!~CarlosRui@ip-95-223-106-12.hsi16.unitymediagroup.de> has quit IRC | 20:38 | |
| *** a42niem <a42niem!~niem@p578b7daf.dip0.t-ipconnect.de> has quit IRC | 21:26 | |
| Not | [IDEMPIERE] Heng Sin Low created IDEMPIERE-4049 Add jersey jax-rs bundles to org.adempiere.target.platform.feature | 22:41 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4049 | 22:41 |
| Not | [iDempiere] 1 commit to default [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ | 23:27 |
| Not | [iDempiere] hengsin 8e31c79 - IDEMPIERE-4049 Add jersey jax-rs bundles to org.adempiere.target.platform.feature | 23:27 |
| Not | [IDEMPIERE] Heng Sin Low updated IDEMPIERE-4049 status set to "Resolved" -Fix Version set to "6.2z" -resolution set to "Fixed" | 23:28 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4049 | 23:28 |
| Not | [IDEMPIERE] Heng Sin Low updated IDEMPIERE-4006 assignee set to "Elaine Tan" | 23:34 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4006 | 23:34 |
| Not | [iDempiere] jenkins build #180 started http://ci.idempiere.org/job/iDempiere/180/ | 23:51 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!