| *** a42niem <a42niem!~niem@2003:a:57d:3200:3885:8824:a8d3:906c> has joined #idempiere | 06:19 | |
| *** nmicoud <nmicoud!~Nicolas@riv38-2-78-235-108-177.fbx.proxad.net> has joined #idempiere | 06:57 | |
| *** brent- <brent-!~brent@207.89.23.133> has joined #idempiere | 07:12 | |
| *** brent_ <brent_!~brent@c-73-96-165-11.hsd1.wa.comcast.net> has quit IRC | 07:12 | |
| *** a42niem <a42niem!~niem@2003:a:57d:3200:3885:8824:a8d3:906c> has quit IRC | 08:14 | |
| *** CarlosRuiz <CarlosRuiz!~CarlosRui@aftr-37-201-193-12.unity-media.net> has joined #idempiere | 09:34 | |
| *** xapiens <xapiens!~xapiens@190.236.204.78> has joined #idempiere | 10:32 | |
| *** tgi_nmicoud <tgi_nmicoud!~Nicolas@riv38-2-78-235-108-177.fbx.proxad.net> has joined #idempiere | 12:57 | |
| *** nmicoud <nmicoud!~Nicolas@riv38-2-78-235-108-177.fbx.proxad.net> has quit IRC | 13:00 | |
| tgi_nmicoud | Hello CarlosRuiz, did you get my email with the pictures ? | 13:04 |
|---|---|---|
| *** tgi_nmicoud is now known as nmicoud | 13:07 | |
| CarlosRuiz | Hi nmicoud - yes :-) very funny pictures | 13:12 |
| nmicoud | :D | 13:12 |
| nmicoud | CarlosRuiz: did you see https://groups.google.com/forum/#!topic/idempiere/XZdZq4MQ2UM ? I will have to manage it, so... as always... Jira ticket ? | 13:36 |
| CarlosRuiz | yes, it sounds like a improvement | 13:42 |
| nmicoud | Ok, i will do that | 13:42 |
| CarlosRuiz | what you mention about callout doesn't sound too generic | 13:42 |
| CarlosRuiz | I think it would be better something more generic - if the window has a field with any record filled must be taken into account | 13:43 |
| CarlosRuiz | for New - and also for the Update case | 13:43 |
| nmicoud | Ah... you mean the change must be done in the QuickEntry panel directly ? | 13:43 |
| nmicoud | and if called from C_BPartner_ID field, then it should fill BPLocation_ID and AD_User_ID fields ? | 13:44 |
| nmicoud | With I guess a hardcoded rule for C_Order.InvoiceBPartnerID | 13:44 |
| CarlosRuiz | I haven't seen how it works for the invoiceBP case | 13:47 |
| CarlosRuiz | yes - sounds like a hardcoded rule | 13:47 |
| CarlosRuiz | and yes - I mean in general - not just BP - the case can be extended for other windows too | 13:47 |
| nmicoud | So idea is to add automatisms when the QuickEntry panel closes, right ? | 13:51 |
| nmicoud | Not creating other callouts | 13:51 |
| CarlosRuiz | I don't remember how is the mechanism how QuickEntry is filling the field value | 13:55 |
| CarlosRuiz | but yes - wherever that mechanism happens - try to extend it | 13:56 |
| nmicoud | there is a actionSave method, but I think callouts of tables are also called. Will have a look | 13:57 |
| CarlosRuiz | no - no callouts | 13:58 |
| CarlosRuiz | because that's working in all windows | 13:59 |
| *** RecordingBot` <RecordingBot`!~supybot@www.globalqss.com> has joined #idempiere | 14:01 | |
| tgi_nmicoud | And yes, callouts are called ; see in actionSave (around line 419) -> // Call all callouts to allow quick entry special behavior | 14:04 |
| CarlosRuiz | I think the thing is in WTableDirEditor and WSearchEditor | 14:05 |
| CarlosRuiz | where you see this line | 14:05 |
| CarlosRuiz | int result = vqe.getRecord_ID(); | 14:05 |
| *** nmicoud <nmicoud!~Nicolas@riv38-2-78-235-108-177.fbx.proxad.net> has quit IRC | 14:09 | |
| *** RecordingBot <RecordingBot!~supybot@www.globalqss.com> has quit IRC | 14:09 | |
| tgi_nmicoud | What do you mean by "the thing is" ? | 14:10 |
| tgi_nmicoud | ah ok, I get it | 14:15 |
| Not | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3914 status set to "Resolved" -resolution set to "Cannot Reproduce" | 14:43 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3914 | 14:43 |
| tgi_nmicoud | CarlosRuiz : debugging here. If i open the QE panel from Invoice window, the CalloutInvoice.bpartner is called when the QE closes. But AFAIU, callouts are called because a change is done on the field (they are not called 'directly' by the QE panel) | 14:46 |
| CarlosRuiz | correct | 14:49 |
| CarlosRuiz | that's what I understand too | 14:49 |
| tgi_nmicoud | That's why my 1st idea was to add a callout for opportunity. Less generic, but easier to handle specific rules (such as InvoiceBPartner_ID) | 14:51 |
| CarlosRuiz | yep - that sounds like a customization easier to write - but for core would be better a generic solution | 14:56 |
| tgi_nmicoud | What I propose : First, write the OpportunityCallout and then create another ticket to have a generic way. | 15:03 |
| tgi_nmicoud | But the migration will not be easy as I think all implementations have specific callouts. So they should be migrated into the "new generic" | 15:03 |
| CarlosRuiz | didn't understand - the callout will be your customization | 15:04 |
| tgi_nmicoud | Ah, ok | 15:04 |
| CarlosRuiz | and new generic is not about callouts - is about quick entry behavior :) | 15:04 |
| tgi_nmicoud | yes, new generic will replace what callouts are doing now (fill location from bpartner) | 15:05 |
| CarlosRuiz | but I think the callout on BPartner is not filling the user from the quick entry - must be filling is something like "the first user found" | 15:09 |
| tgi_nmicoud | That's right. But it's ok when you open the QE panel in "New" mode | 15:09 |
| tgi_nmicoud | as there is only one contact | 15:10 |
| *** brent- <brent-!~brent@207.89.23.133> has quit IRC | 16:27 | |
| *** brent_ <brent_!~brent@207.89.23.133> has joined #idempiere | 16:31 | |
| Not | [IDEMPIERE] hieplq created IDEMPIERE-3915 support customize workflow node on workflow editor | 16:34 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3915 | 16:34 |
| Not | [IDEMPIERE] hieplq updated IDEMPIERE-3915 Sprint set to "" -labels set to "+Patch" -Attachment set to "IDEMPIERE-3915.patch" | 16:37 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3915 | 16:37 |
| Not | [IDEMPIERE] hieplq updated IDEMPIERE-3915 status set to "Peer Review Queue" | 16:37 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3915 | 16:37 |
| *** tgi_nmicoud <tgi_nmicoud!~Nicolas@riv38-2-78-235-108-177.fbx.proxad.net> has quit IRC | 16:43 | |
| *** CarlosRuiz <CarlosRuiz!~CarlosRui@aftr-37-201-193-12.unity-media.net> has quit IRC | 17:37 | |
| Not | [IDEMPIERE] hieplq updated IDEMPIERE-3915 description set to "[~jray] sponsor to make a graph to show workflow status of document. almost done on plugin (ssh://hg@bitbucket.org/idplugin/tw.idempiere.document.wf.graph). i reuse WFEditor for draw graph so need to improve core for easy to extend this issue to manage that change" | 17:39 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3915 | 17:39 |
| *** a42niem <a42niem!~niem@2003:a:57d:3200:3885:8824:a8d3:906c> has joined #idempiere | 17:55 | |
| *** a42niem <a42niem!~niem@2003:a:57d:3200:3885:8824:a8d3:906c> has quit IRC | 21:07 | |
| *** CarlosRuiz <CarlosRuiz!~CarlosRui@aftr-37-201-193-12.unity-media.net> has joined #idempiere | 21:44 | |
| *** CarlosRuiz <CarlosRuiz!~CarlosRui@aftr-37-201-193-12.unity-media.net> has quit IRC | 22:38 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!