#idempiere IRC log for Friday, 2015-04-24

*** CarlosRuiz has quit IRC00:16
*** is-mw2 has joined #idempiere01:50
*** is-mw has quit IRC01:50
*** HansR42 has quit IRC02:02
*** red1_ has joined #idempiere03:36
*** ChanServ sets mode: +o red1_03:36
*** RecordingBot has joined #idempiere04:32
Not-3656[IDEMPIERE] red1 created IDEMPIERE-2594 RMA does not allow repeat returns on same shipment.04:49
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259404:49
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "SubtractPreviousRMA.patch"04:49
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259404:49
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "Balance3.png"04:50
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259404:50
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 description set to "During Customer RMA, the Shipment selected if has previous RMA still shows the same MovementQty/Delivered Qty for selection and then will give error during adding due to returned been higher than shipped before even though it was not completely returned in partial cases. With this patch, it shows original and moved qty so that when adding the balance, it goes through without issue. Testing wi04:53
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259404:53
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 status set to "Peer Review Queue"05:17
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259405:17
*** a42niem has joined #idempiere06:05
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "None"06:12
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259406:12
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "MultiPartialRMA.patch"06:13
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259406:13
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 description set to "During Customer RMA, the Shipment selected if has previous RMA still shows the same MovementQty/Delivered Qty for selection and then will give error during adding due to returned been higher than shipped before even though it was not completely returned in partial cases. With this patch, it shows original and moved qty so that when adding the balance, it goes through without issue. Testing wi06:17
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259406:17
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "BeforePatch.png"06:25
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259406:25
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 description set to "During Customer RMA, the Shipment selected if has previous RMA still shows the same MovementQty/Delivered Qty for selection and then will give error during adding due to returned been higher than shipped before even though it was not completely returned in partial cases !BeforePatch.png|thumbnail! With this patch, it shows original and moved qty so that when adding the balance, it goes throug06:25
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259406:25
*** KermitTheFragger has joined #idempiere06:28
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "IDEMPIERE-2594.patch"08:10
Not-3656[IDEMPIERE] Added non zero trigger for checkQty to disallow proceeding when balance is zero. More display friendly to use than not which allows passing thru of full qty and then stopping it.08:10
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259408:10
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-259408:10
Not-3656[IDEMPIERE] Better patch - Added non zero trigger for checkQty to disallow proceeding when balance is zero. More display friendly to use than not which allows passing thru of full qty and then stopping it.08:11
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259408:11
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "ZeroCaseTrigger.png"08:19
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259408:19
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-259408:20
Not-3656[IDEMPIERE] Better patch - Added non zero trigger for checkQty to disallow proceeding when balance is zero. More aesthetic to use than not which allows passing thru of full qty and then stopping it. !ZeroCaseTrigger.png|thumbnail!08:20
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259408:20
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 priority set to "Minor"08:20
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259408:20
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "None"08:28
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259408:28
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 status set to "Resolved" -resolution set to "Incomplete"08:40
Not-3656[IDEMPIERE] Testing with multi lines fail. Needing some more work08:40
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259408:40
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 status set to "Reopened" -resolution set to "None"08:40
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259408:40
*** red1_ has quit IRC09:23
*** red1 has quit IRC12:21
*** CarlosRuiz has joined #idempiere13:29
*** ChanServ sets mode: +o CarlosRuiz13:29
*** KermitTheFragger has quit IRC15:08
*** norbertbede has joined #idempiere16:19
norbertbedehi16:19
norbertbedeany idea how first create invoice then match later generated shipment lines with invlice lines ?16:20
norbertbedewould be opt1. auto-allocate opt2. matching improvement opt3 any other idea16:21
CarlosRuizactually I see that flow is not supported on sales16:22
norbertbedewe could develop and commit16:22
norbertbedewhat you suggest16:22
norbertbedeits stopper for us on project now16:22
CarlosRuizyou can always invoice a sales order without shipping - and ship later16:23
norbertbedejust how "match" lines ?16:23
CarlosRuizno, not matching concept on sales - is direct16:23
norbertbedec_invoiceline has c_inoutline_id16:24
norbertbedethat is what i want somehow match/allocate16:24
norbertbedei know matching has additional matching process16:25
norbertbedei see16:25
norbertbedebut independently when i will create first invoice then shipment i still want connect them16:25
norbertbedeot thinking about improve generate shipment by - allocate shipment lines to invoice lines...16:31
norbertbedethis should be auto mode16:31
norbertbedethen reconcile those lines16:31
CarlosRuizI think they're linked in the orderline - the invoiceline points to an orderline - and same for the inoutline16:32
norbertbedethere should 1:N (1 orderline multiple shipment/invoice lines) relationship im not sure that is possible16:34
*** norbertbede1 has joined #idempiere16:52
*** norbertbede has quit IRC16:55
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "None"17:09
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259417:09
Not-3656[iDempiere] CarlosRuiz_globalqss pushed 2 commits to development [+5/-0/±10] https://bitbucket.org/idempiere/idempiere/commits/17:09
Not-3656[iDempiere] druiz_bxservice b45f48c - Add functionality to allow user preference window configurable17:09
Not-3656[iDempiere] globalqss 1861093 - IDEMPIERE-2556 User preferences window configurable / peer review17:09
Not-3656[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2556 status set to "Resolved" -resolution set to "Fixed"17:09
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-255617:09
*** norbertbede1 has quit IRC17:11
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "IDEMPIERE2594.patch"17:11
Not-3656[IDEMPIERE] Finally solved it and tested in multi line partial triple returns. Dirty hack seems to hold against the checkQty doing an init() to overwrite the returning balance. At least this fills such feature hole of RMA.17:11
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259417:11
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 status set to "Peer Review Queue"17:11
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259417:11
Not-3656[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-255617:12
Not-3656[IDEMPIERE] https://bitbucket.org/idempiere/idempiere/commits/b45f48 https://bitbucket.org/idempiere/idempiere/commits/186109317:12
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-255617:12
*** red1 has joined #idempiere17:13
red1hola CarlosRuiz i know its not wednesday meeting but i am motivated to conclude a https://idempiere.atlassian.net/browse/IDEMPIERE-259417:14
red1it solves a feature hole in RMA as the way Material Receipts allow partial receipts17:14
red1now it works except there is a small workaround inside to make it more appealing during zero balance17:15
red1its not required by customer here in Austria but i was itching to make it work for fun :D17:16
CarlosRuizHi RecordingBot17:18
CarlosRuizHi red117:18
CarlosRuiz:-)17:18
CarlosRuizI'm greeting the bot17:18
CarlosRuizreading the patch (not tested)17:19
CarlosRuizwhere you check the sum of other rmalines17:19
CarlosRuizyou must check also for the status of the RMA17:20
red1in the patch it takes the SUM(rmal.Qty) from the previous17:20
CarlosRuizdon't add if the RMA is draft or void17:20
red1the SQL done by Hengsin was already nearly perfect17:20
CarlosRuizI think usually just CL/CO must be taken into account17:20
red1hengsin SQL handles all that17:20
red1except that it stops repeat returns17:20
CarlosRuizwhich hengsin sql?17:21
red1CreateFromRMA17:21
red1it is copyrighted him17:21
red1though author was Teo17:22
CarlosRuiz:-) you better check the author of the line17:22
CarlosRuizthose lines were changed by elainetan17:22
CarlosRuizbut - still17:22
red1anyway, the Create From button seems to be disable if its not allowed17:22
CarlosRuiz<CarlosRuiz> where you check the sum of other rmalines17:23
CarlosRuiz<CarlosRuiz> you must check also for the status of the RMA17:23
CarlosRuiz<CarlosRuiz> don't add if the RMA is draft or void17:23
CarlosRuiz<CarlosRuiz> I think usually just CL/CO must be taken into account17:23
red1i see17:23
CarlosRuizand the hack to change the qty from 0 to 1 sounds strange - I haven't tested but don't understand why you would need that17:23
red1ok i understand17:23
red1during a RMA.. customer may not return all items17:23
red1but later found more to return17:24
red1and he could not do that anymore17:24
red1thanks for your quick advice which you are correct17:25
red1i did not check if the RMA docstatus is not valid17:25
red1so i should be solving it before this wednesday meeting17:26
red1for it then17:26
*** norbertbede has joined #idempiere17:30
CarlosRuizred1,17:32
CarlosRuizit could be a simpler patch17:32
CarlosRuizmaybe you can test this approach17:33
CarlosRuizhttp://pastebin.com/5QF17Ru817:33
CarlosRuizis just to make the qty editable17:33
*** red1 has quit IRC17:45
hieplqhi @CarlosRuiz, i see you commit IDEMPIERE-2556. i want test it a bit. how to add new user preference value?18:05
CarlosRuizHi hieplq18:07
CarlosRuizvery easy now - you just need to add a column in the table AD_UserPreference18:08
CarlosRuizand add a field in the window "User Preference"18:08
CarlosRuizif you want the preference shown in the popup window - then you mark the field as quick entry18:09
hieplqthanks, will test it.18:10
CarlosRuizgreat - any feedback is appreciated18:10
*** red1 has joined #idempiere18:15
*** ChanServ sets mode: +o red118:15
*** red1 has quit IRC18:17
*** red1 has joined #idempiere18:18
*** ChanServ sets mode: +o red118:18
red1Thanks for the tip.. Studying it...18:20
red1Yes it can work in conjunction with the other patch which merely fetches the balance18:21
red1No need to go to detail line row18:22
red1Is so sexy now18:30
Not-3656[IDEMPIERE] hieplq updated IDEMPIERE-255618:31
Not-3656[IDEMPIERE] from my mistake, i see below case. 1. after add new column into table user preference (also create field for it). i forget run sync column. 2. I log out and can't login by error "ERROR: column "newpreference" does not exist" I suggest add try catch to line 69, class MUserPreference. with system user. show a warrning and still allow login to fix issue by run sync column.18:31
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-255618:31
red1And the create from shipment window should also not show nil qty records18:31
red1And allow more shipment records18:32
red1In one RMA18:33
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "editable minitable.png"19:09
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259419:09
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-259419:11
Not-3656[IDEMPIERE] Carlos Ruiz gave the following single word change: diff -r 1861093d9de8 org.adempiere.ui/src/org/compiere/grid/CreateFromRMA.java --- a/org.adempiere.ui/src/org/compiere/grid/CreateFromRMA.java Fri Apr 24 12:08:56 2015 -0500 +++ b/org.adempiere.ui/src/org/compiere/grid/CreateFromRMA.java Fri Apr 24 12:32:57 2015 -0500 @@ -136,7 +136,7 @@ miniTable.setColumnClass(2, String.class, true); // 2-Product miniTable.setColumnClass(3, String.class,19:11
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259419:11
Not-3656[IDEMPIERE] red1 updated IDEMPIERE-259419:11
Not-3656[IDEMPIERE] Carlos Ruiz gave the following single word change: diff -r 1861093d9de8 org.adempiere.ui/src/org/compiere/grid/CreateFromRMA.java --- a/org.adempiere.ui/src/org/compiere/grid/CreateFromRMA.java Fri Apr 24 12:08:56 2015 -0500 +++ b/org.adempiere.ui/src/org/compiere/grid/CreateFromRMA.java Fri Apr 24 12:32:57 2015 -0500 @@ -136,7 +136,7 @@ miniTable.setColumnClass(2, String.class, true); // 2-Product miniTable.setColumnClass(3, String.class,19:11
Not-3656[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-259419:12
*** red1_ has joined #idempiere20:11
*** red1_ has quit IRC20:38
*** norbertbede has quit IRC21:27

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!