#idempiere IRC log for Friday, 2015-02-20

*** is-mw2 has joined #idempiere02:12
*** is-mw has quit IRC02:13
shmutalovGood morning to all! )02:39
*** hieplq has joined #idempiere03:09
*** hieplq has quit IRC05:16
*** hieplq has joined #idempiere05:18
*** shmutalov has quit IRC05:45
*** shmutalov has joined #idempiere05:54
shmutalovQ: Where is "Currency" column in "Order Lines", when I making purchase order?06:06
shmutalovCurrency Rate06:07
shmutalovWhere I can setup and refresh values of currency rates,06:11
shmutalov?06:11
*** Harsh has joined #idempiere07:04
JanThielemanngood morning07:11
JanThielemannshmutalov are you there?07:14
shmutalovYep07:14
JanThielemannidempiere is multi currency ready07:14
shmutalovI found only "Import conversion rate"07:14
JanThielemannyou have to define the currencies and conversion rates you want to use07:14
JanThielemannthen on the sales order07:15
JanThielemannyou select the currency you want to use for this order07:15
JanThielemannthe price in the orderline should get automatically converted to the selected currency from the order head07:15
JanThielemannyou don't select the currency on sales ordre line level07:15
JanThielemannin the currency window, you define the currencies you can use07:16
shmutalovIt is clear for me now ) But where to define currency?07:16
JanThielemannin the currency window^^07:16
shmutalov)07:17
JanThielemannthen for each conversion you need, e. g. dollar<>euro, dollar<>rubel, you have to define a conversion rate07:17
JanThielemannopen the currency window and chose us dollar07:17
JanThielemannin garden world you should see conversion rates to euro07:17
shmutalovI cant find currecny window (I am using webUI)07:18
JanThielemannwhich role are you using?07:18
JanThielemannsystem? ;)07:18
shmutalovGardenAdmin07:18
JanThielemannwhich user?07:18
shmutalovGardenAdmin07:19
JanThielemannhmm07:20
JanThielemannlets try it out here: demo.idempiere.com/webui07:20
JanThielemannlogin with superuser @ idempiere.com/System (notice the space between the @ and the words)07:21
shmutalovWhich role I must select?07:21
JanThielemanngardenadmin07:22
JanThielemannsearch for "Curr" and you should already see currency and currency rate windows07:22
shmutalovOk, I found here07:23
shmutalov) Now, I found on my instance too07:25
JanThielemann^07:25
JanThielemann^^ where was it?07:25
shmutalovMy instance is on Russian lang07:25
shmutalovI logged on with System/System07:25
shmutalovBut, I cant log on with different lagn07:26
shmutalovStrange07:26
JanThielemannsystem is not a good user07:27
shmutalovIs System hardly translated after language import?07:27
JanThielemannbetter use SuperUser/System when you play around and need admin rights07:27
shmutalovSystem > ERP07:27
JanThielemannwhen you import a language, you have to run the synchronize terminology process07:27
JanThielemannafterwards07:27
shmutalovIt is not possible to enable two or more translations?07:28
shmutalovFor example, my organization speaks on Russian and Uzbek, but for support I need English07:29
*** norbertbede has joined #idempiere07:29
JanThielemannsure thats possible07:30
JanThielemannyou can install as many languages as you like07:30
JanThielemannif you wnat, you could even create you own klingon translation07:30
*** KermitTheFragger has joined #idempiere07:30
shmutalovOk... I am doing next steps > I installed fresh system > It is on English > Then imported and synchronized Russian > I am choosing Russian lang from log on screen > Interface is on Russian >07:31
shmutalov> I am logging off > Then choose English lang from select box (Log on screen) > Interface still on Russian (wtf?)07:32
JanThielemanncan you reproduce on demo.idempiere.com?07:33
JanThielemannif yes, you could file a ticket in jira07:33
JanThielemannthat sounds like a bug07:33
shmutalovEhmm, I will try07:33
shmutalovI cant import translation from idempiere.org server07:36
shmutalovError occurs07:36
shmutalovhttp://pastebin.com/2dRRyTan07:38
JanThielemannseems like some role access problems on os level+07:43
shmutalovOk, I will try with System user07:43
shmutalovSame problem, can't import07:44
JanThielemannhmm07:53
shmutalovOkey... Next...07:55
shmutalovI disabled all predifined conversion types (Company, Average, Spot, Period End), and created own type (CB RUz). Then, when I want to import conversion rate, I still can choose Spot from select box07:56
shmutalovAnd when I want create conversion rate, I can still choose "Company" type07:57
*** nmicoud has joined #idempiere07:58
JanThielemannif you take a look at  the fields in the application dictionary, you may see that some fields have default values08:02
JanThielemannif e.g. the default value is company, it will be selected on new entries but if you swich it the entrie disappears from the list08:02
JanThielemannin this case, ou have to change the default value for this field in either window tab and field or tables and columens (depending on where it is set)08:02
JanThielemannalso notice that default values can be written to the AD when you use the value preference editor08:03
JanThielemannso there are many options why it is still showing up even if it is deactivated08:03
shmutalovOk. What does mean "Default" checkbox at Conversion Type Window?08:05
JanThielemannmaybe this can help you. it's from adempiere but it should give yyou more information http://blogs.walkingtree.in/2013/02/27/multi-currency-management-in-adempiere/08:09
JanThielemannand the adempiere 3.4 erp solutions book has a chapter about multi currency08:10
JanThielemannhowever, default normaly means that one rate is taken by idempiere by default if oyu don't chose one by yourself08:11
shmutalovLogically true08:12
shmutalovBut I can choose two "default" conversion types )08:13
JanThielemannfor the same currency?08:13
JanThielemanni think this is if you e.g. have a daily rate and a weekly rate for a currency then you can chose the daily rate as default08:14
JanThielemannand that for each currency separately08:14
shmutalovNo, I mean I can define two currecny conversion type with "Default" checkbox is checked08:14
JanThielemannhmm08:14
JanThielemannseems like some validation is mising^08:14
JanThielemann^ ^08:14
JanThielemanndo you know asterisk?08:14
shmutalovAfter I deselected "unused" default conversion type, I can only choose one default conversion type in Currency Rate/Import Currency Rate window08:16
shmutalovWhat I am need ^^08:17
shmutalovWhat is asterisk?08:17
JanThielemanntelephony software08:17
shmutalovLike Skype? But open source?08:18
JanThielemannopen source yes but it is a telephony system. you install it, connect it to your isdn or phone connection and the system handles call forwarding, conferences and stuff like this08:18
JanThielemannworks with ip phones08:18
shmutalovNo, I don't have IP-phone08:19
JanThielemanni'm integrating it in idempiere08:19
shmutalovI read about that somewhere...08:19
JanThielemannnow i can make calls from within idempiere, asterisk calls my phone and when i pickit up, the destination number is dialed08:19
shmutalovYou writing plugin for idempiere08:19
JanThielemannyes08:19
JanThielemannupdating and improving it08:19
JanThielemanni would like to integrate conference calls but asterisk is hard to configure and i have no idea what to do08:20
JanThielemannunfortunately our admin is ill and he cant help me xD08:20
shmutalovWhy ERP need telephony/conference or chat?08:21
JanThielemannimagination my friend :)08:22
JanThielemanntheres a person sitting in an office and he gets a call08:22
JanThielemannin idempiere, a little window pops up and the perosn has the ability to click on a button and directly open the business partner information of the caller08:22
JanThielemannhe or she directly can see the order history and other information08:23
shmutalovOk, it good I think08:23
shmutalovNice08:23
shmutalovSo, if you have phone number of dialer you can select info from db and show it08:24
shmutalovProblem is retrieving phone number from Asterisk?08:24
JanThielemannanother example: you are approving a order because you are the head of the department. you have a question about the order so you zoom into the sales representant, hit the call button and cann talk to him08:24
JanThielemannno theres no problem with the lookup except some minor difficulties i'm thinking about (e.g. two persons have the same number, user and org have the same number, etc.)08:25
JanThielemannmy current problem is different. I want conference calls but i cant find out how to initiate them via software08:25
JanThielemannalso i believe the asterisk server need some additonal configuration08:26
*** moder has joined #idempiere08:26
shmutalovGood solution, but we still using oldschool telephony )08:31
shmutalovI am reading about automatization of conference creation in habrahabr08:34
shmutalovMaybe you need read it, but it is in Russian )08:35
shmutalovhttp://habrahabr.ru/post/182270/08:35
JanThielemannlooks like noodle soup to me xD08:36
shmutalov)08:37
shmutalovWhat I understand is: Write new conference info (conference number, password) into asterisk configuration file "/etc/asterisk/meetme_additional.conf", then reload asterisk with command: /usr/sbin/asterisk -rx "reload"08:42
JanThielemannfirst you need to install the meet me application in asterisk and as far as i understand, you have to use make and recompile it08:42
JanThielemanni won't do this. this is our admins task^ ^08:42
JanThielemanni don't want to be responsible if we cant use our phones for a day08:43
shmutalov)08:45
shmutalovAre you using JasperReports as reports generation system?08:58
JanThielemannyes09:21
shmutalovWhich designer are using?09:23
JanThielemannyou better ask adnan09:24
JanThielemannhttps://www.youtube.com/watch?v=qupDLprUoJE09:24
JanThielemanni'm not so good with reports :P09:24
shmutalovWe have restriced access to media/social sites XD09:24
posdeshmutalov, I've downloaded it for you to: http://possy.de/customizingjasper.mp4 in case you can get to that .It is around 340MB - Let me know, when you downloaded it, so that I can remove it.09:29
shmutalovO_O09:30
shmutalovThank you very much, but you can delete it now )09:30
posdeok.09:30
shmutalovI will review all of given links next month09:30
shmutalovFrom my home09:30
posdeWho is from Algeria and wanted the file as well?09:40
posdemoder, ?09:40
*** moder has quit IRC10:17
*** mder has joined #idempiere10:21
*** mder has left #idempiere10:21
*** moder has joined #idempiere10:21
*** Mbogning has joined #idempiere10:22
*** Mbogning has quit IRC10:23
*** moder has quit IRC10:23
*** Harsh has quit IRC10:35
*** a42niem has joined #idempiere10:52
*** moder has joined #idempiere11:13
*** sysdev has joined #idempiere11:42
*** connit has joined #idempiere11:43
*** sysdev has quit IRC11:43
*** red1 has joined #idempiere13:40
*** moder has joined #idempiere13:42
*** ChanServ sets mode: +o red113:44
red1Hi all, like to ask is it OK to maintain a private feature and then announce it publically? Is it against GPLv2?13:45
*** akirdi has joined #idempiere13:54
posdered1, no.14:00
red1I am referring to http://www.chuckboecking.com/project-manufacturing-explode-project-template-bom-components/14:00
posdeas long as you are keeping a feature for yourself and not selling it or giving it to third parties, it is okay to keep it privately.14:00
red1it is something that i can reproduce easily14:00
posdered1, does my comment make sense?14:01
red1of course14:01
red1so whaet do u think in the link above14:01
red1its under the guise sold as membership14:01
posdeGosh, now I must really read something :) Just a sec.14:02
red1and as part of training14:02
red1I paste for u.. "The below video demonstrates a process that is not available in the iDempiere core application. It is maintained in a a private repository. If you are or have ever been a member of the ERP Academy, you may request access to the repository for no additional charge."14:02
posdeTo me, it sounds like a violation of terms to the GPL.14:02
red1Indeed, i was upset but then that is me14:03
red1But how do i state that its a violation?14:03
red1If i am challenged, "how is it so?"14:03
posdeIt is not a private entity, but anyone has access to it by paying a fee. That is, imho, not in accordance to the GPL.14:03
red1its OK to pay a fee, but it must be open source in essence14:04
posdeyep14:04
red1u can sell the binary for a fee14:04
posdeyep.14:04
posdebut you have to provide the changes back as gpl14:04
red1or sell the training or sell the skype session to help install it14:04
red1thus i can ask 'under what license is that distributed, fee nowithstanding?"14:05
posdered1, if it really bothers you, and I would understand if it does, I would check with the lawyers of the EFF14:05
red1great14:05
posdeThey know for sure.14:05
red1it does bother me because i have more stories behind this story14:05
red1from other parties who are doing things quietly14:06
red1and let to continue will u know, lead to something serious in future.14:06
posdeprobably. It is a very delicate subject.14:06
red1i want to advice those parties personally but have to first understand the legal side if any14:06
posdeI personally, do not understand why people that utilize GPLed software do not feel honoured to supply back their changes.14:07
red1indeed, they already took others work freely without paying14:07
red1if they were pushing SAP then do that14:08
red1the work there in Project (Order) was pushed to Carlos to commit as FOSS14:08
red1and then added onto it something closed14:08
*** CarlosRuiz has joined #idempiere14:10
*** ChanServ sets mode: +o CarlosRuiz14:10
red1i have always worried that someone does not understand GPL thus our project or the project we should be supporting14:10
posdeAlways a problem.14:12
posdeWe, LinuxMCE, have something similar. Even though we are not GPL, we do have a specific OSS licence, which prohibits selling hardware or installation with our software. Every now and then, some slimy grey idiot comes by and tries to do just that. And when they fail at their customer site, they send the customer into OUR IRC.14:14
CarlosRuizHi14:16
posdehi CarlosRuiz14:17
CarlosRuizred1, GPL compels to distribute the source if you distribute the binaries14:18
CarlosRuizit is not mandatory to publish everything to everyone14:18
red1What if the binaries are given in a paid forum?14:18
CarlosRuizthat's fine14:19
red1If i pay for the forum? Do i get access to its source?14:19
CarlosRuizthat's what I understand - ERP academy members have access to the sources14:19
red1So under what license do i access the source?14:20
CarlosRuizthe source must be GPL I suppose14:20
red1Thus can i then give it away freely?14:20
CarlosRuizI haven't seen the sources14:21
CarlosRuizbut if they're GPL as I suppose14:21
CarlosRuizany member with access to the sources have all the freedoms14:21
red1Let's say i do not wish to make it GPL, i make a plugin as non GPL to run on iDempiere, is that OK?14:21
red1But i am using GPL code such as SvrProcess14:22
CarlosRuizno - not ok14:22
CarlosRuizif you want to make a private code with a different license than GPLv2 - then I think you must connect to idempiere via web services14:23
red1And that 3rd party code must NOT use GPLed as base or interface?14:23
*** claoudio has joined #idempiere14:24
CarlosRuizno, if they use a GPL library or code then it must be GPL too14:24
*** claoudio has quit IRC14:24
CarlosRuizdifferent if they use a LGPL library - that's a different license that allows usage without making the code GPL14:24
CarlosRuizbut all *mpiere code is GPLv2 and that cannot be changed14:25
red1There are two distintive questions here: (1) Can i distrubute binary in closed manner? (2) Can i distribute source in closed manner?14:25
CarlosRuizbut I think the key point is - you're not forced to publish the sources to everybody - just to the people you distribute the binaries14:26
posdeIf you distribute a binary with GPL, the recipient of the binary can demand the source code.14:26
red1From your answer, (1) is yes it can be closed or sold , (2) is ??14:26
CarlosRuizyou can distribute sources in a closed manner14:26
CarlosRuizbut you cannot force the people receiving the sources to not distribute it14:26
red1I thought (from what Linus said in a talk) you 'should' send back the originator your changes (in spirit)14:26
CarlosRuizI guess some companies can try to give you sources and force you to sign a NDA - but I think that's a practice against the GPL (not talking about this case)14:27
red1So if i send u sources to commit, and then i made new sources and not send u selectively, i wonder if its a game..14:27
CarlosRuizno, AFAIR it's not mandatory to sent back sources to the originator - is mandatory to publish to the people you give binaries14:28
red1I thought GPL clearly states that the freedom is not to be stopped.. but i may be reading it wrongly14:29
CarlosRuizhttp://www.gnu.org/licenses/old-licenses/gpl-2.0-faq.en.html#GPLRequireSourcePostedPublic14:30
red1OK, then what is the meaning of "But if you release the modified version to the public in some way"?14:31
red1Doea it apply in the case above?14:32
red1is it 'public in some way' when it is stated 'private'14:32
CarlosRuizI think advertising is not releasing14:32
red1Thus that clause does not apply IMHO14:32
red1Thus he is not compelled to do so, but then (here is the catch) can he then distribute the binary of it?14:33
CarlosRuizanybody can distribute a binary plugin - or a modified idempiere base14:34
red1This is very clear, "You are free to make modifications and use them privately,"14:34
CarlosRuizGPL forces in such case to be accompanied with the sources (or a written offer valid for any third party)14:34
CarlosRuizthe keyword is "distribute" - I assume distribute is providing you the binaries14:35
red1Now in the case above, it is not used internally or privately but 'promised to deliver' thus part of non private use14:35
red1NO, i dont think your quote refers to binaries14:35
CarlosRuizI understand that - advertising in a video is not distributing14:35
red1Where is there a distinction of binary and source in that GPL clause?14:36
red1What i read is the distinction between private use and public use14:36
red1OK, it is advertising, but is it 'distributed in some way'?14:36
red1To me spirit of GPLv2 is very clear, you are free to use it privately and no one knows about it, but once you make any public announcenment..14:37
red1it is obvious the public announcement is to serve a purpose..14:37
posdeAs one can see from you guys discussion, GPL, or licensing in general is very complex, hence my statement to ask the people that do this everyday, the lawyer of the EFF14:37
red1i know posde i do not disagree with the intent to refer to lawyer, but i am just postulating how a clause is normally read14:38
CarlosRuizhttp://www.gnu.org/licenses/gpl-2.0.html14:38
red1if u use it privately is clear, and in this case a simple question is 'is it use privately'?14:38
CarlosRuizgplv2 doesn't talk about private/public - it talks about distribute14:39
posdered1, I stopped trying to understand legalese when a judge told me that I haven't paid the seller, even though I had the signature of the seller that he had received the money.14:39
red1posde: i agree with the judge as it depends on things other than signature14:39
red1it depends on what the law says not what u say14:40
red1in our case, the GPL law refers to freedom14:40
posdeSee, that's why I stopped trying to understand it, cause IANAL14:40
red1Your case is clearly limited, u are referring to a signature without referring to the law14:40
red1i studied English Law first year and skipped the exams :)14:41
* posde never studied anything, and just lives by the thing called common sense.14:41
red1To me the law is trying to make life easy for users but not developers14:41
red1or software makers, the original case that RMS brought against HP and Bell Labs14:42
red1is not to rob others of the freedom from your work14:42
red1There is a principle in law called 'mischief rule' which is 'what is the law intended to solve in a real life problem'?14:43
CarlosRuizGPLv2 is our license - we cannot stick other rules that are not explicit there14:45
CarlosRuizthe other common case is that anybody can run a SaaS version of idempiere without being forced to publish the sources - that's legal14:46
CarlosRuizas you're not distributing binaries14:46
red1That i agree, because there is no intend to do distribute software14:46
red1And u are maintaining a service14:47
red1but if u are not maintaining a service but a business that says, "i will give you software to use' that is clearly distribution and GPLv2 promptly states it is thus your decision to do so and thus it must respect the freedom14:48
red1or 'software to apply, to plugin, maintain yourself etc'14:49
CarlosRuizyes - and it is - the GPLv2 says that if you distribute the binaries you must distribute the sources - I don't see the issue with announcing a source in a video to a private club14:49
CarlosRuizI would see the issue if the source is provided to the private club with a different license or trying to stop them from redistribute14:49
CarlosRuizbut we don't know if that's the case (and I think is not)14:50
red1its a good game :)14:52
red1selling a private club based on a modified version but claiming as "an organization can make a modified version and use it internally"14:58
*** hieplq has quit IRC15:19
*** dalmotli has joined #idempiere15:39
*** dalmotli has left #idempiere15:40
*** dalmotli has joined #idempiere15:43
*** dalmotli has joined #idempiere15:46
*** dalmotli has quit IRC15:47
*** red1 has quit IRC15:57
*** delemo has joined #idempiere16:05
*** delemo has joined #idempiere16:11
*** norbertbede has quit IRC16:15
*** akirdi has quit IRC16:20
*** delemo has quit IRC16:20
*** norbertbede has joined #idempiere16:20
*** is-mw2 has quit IRC16:37
*** KermitTheFragger has quit IRC17:22
*** norbertbede has quit IRC17:25
*** norbertbede has joined #idempiere18:14
*** norbertbede has quit IRC19:04
*** norbertbede has joined #idempiere19:05
norbertbedeHI CarlosRuiz20:00
CarlosRuizHi norbertbede20:00
norbertbedeI saw your photos in ecuador looks cool :)20:01
norbertbedei mean on fb20:01
CarlosRuizthe volcano?20:01
norbertbedeyep20:01
CarlosRuizyes, nice, very hard to walk at such height20:01
norbertbedeand we are in the same time working hard here :)20:02
CarlosRuiz:)20:02
norbertbedejust a small joke20:02
norbertbedeenjoy20:02
norbertbedejust want ask someting if you have time20:02
norbertbedenot an urgent just ask your advice20:03
norbertbedeits related to product searching and indexing.20:03
CarlosRuizyep?20:03
norbertbedeim imported 22000 products ti m_product20:03
norbertbedei trying to search by name eg. %toners%20:04
norbertbedeand this approx 8 sec20:04
norbertbedemeanwhile a met a man whis is quite experienced with topics of fuzzy indexing and other techcs20:05
norbertbededo you mean can we speedup generally that ?20:05
norbertbedesure i can move to better server, but im interesing how to make it better on same capacity20:06
CarlosRuizsearching with a % at the start is the most expensive as it requires a full scan of the table20:07
norbertbedei know that this why im asking its good to thinking another technilogies to speed up20:07
CarlosRuizand you cannot have a proper index to speed up such search20:07
CarlosRuizthe possibilities I've seen is to use for example lucene to do text search20:08
norbertbedeyes that is one option20:08
norbertbedehe recommend20:08
norbertbedejust not idea its real to implement ur setup to idempiere20:08
CarlosRuizthe other I have thought is using postgresql text search20:09
CarlosRuizhttp://www.postgresql.org/docs/9.4/static/textsearch.html20:09
CarlosRuizI think lucene or postgresql text search can be done as plugins20:10
norbertbedehm. that could be very cool. looks something "complicated" ?20:10
norbertbedein first look20:10
norbertbedewdyt20:10
CarlosRuizit depends - maybe is not that complex20:11
norbertbedewhere to start :)20:11
CarlosRuizto have a definition about what you want to index (a couple of tables maybe) - a process to index/reindex - maybe a validator that index/reindex on record changes20:12
norbertbedei can give it to tomassvikruha maybe some advice - because he primarily wotrk with business logic - would good20:12
CarlosRuizand a form to do the query and show the navigable results to user20:12
norbertbedethis looks good start i think as advice20:13
norbertbedeok. then i will ask others like hiep, tomas and my mentioned man who understand to20:13
norbertbedeok. than enjoy your holiday/job :)20:14
norbertbededont want disturb you20:14
CarlosRuizI'm working now - past week was teaching a training in Ecuador20:14
*** beltin has joined #idempiere21:06
*** JanLeMann has joined #idempiere21:34
JanLeMannhello guys21:34
JanLeMannanybody here? nmicoud, norbertbede?21:34
nmicoudpresent !21:34
JanLeManncan you check the chart display types sql class?21:35
JanLeManni think i found a bug when i recorded a video today21:35
JanLeManni createed a new chart column and wasn't able to synchronize it to the database21:35
nmicouddo you reproduce it in demo.idempiere.com ?21:36
JanLeMannbecause it should be id number but idempiere tried to create it as a text field21:36
JanLeManni recorded it on demo.idempiere.com^^21:36
nmicoudxd21:36
JanLeManntemporary workaround: using number to synchronize and swtich to chart afterwards21:37
nmicoudmaybe 6 months ago, i created a new column (of chart type) ; and it was ok21:37
nmicoudcould you give me the class which contains the sql type ?21:37
nmicoudi do not remember (and i'm quite lazy in the evening :)21:38
JanLeMannDisplayType21:39
nmicoudthanks21:39
JanLeMannnear the end of the class21:39
JanLeMann^^21:39
nmicoudseems the column is created as VARCHAR2, right ?21:40
JanLeMannyes21:40
JanLeMannbut it should be a number like id21:40
nmicoudit will be an integer if the column ends with _ID21:40
nmicoudsee line 58421:40
JanLeMannah thats why nobody noticed before21:41
JanLeMannmy column was named evechart or so21:41
JanLeMannchart display type should be isID true21:41
JanLeMannand sql type should be number(10,0)21:41
nmicoudchart are considered as ID21:42
nmicoudlike Image, maybe we should add something like   if displaytype = Chart  return "NUMBER(10)    wdyt ?21:43
JanLeMannyes21:43
JanLeMannlet me check demo.idempiere.com again21:43
JanLeManncan you tell me the package and bundle displaytype.java is in?21:44
nmicoudorg.compiere.util.DisplayType21:44
nmicoudorg.adempiere.base21:44
JanLeMannhuston we have a problem here:21:48
JanLeMannelse//EntityType, AD_Languagefallback return "VARCHAR2(" + fieldLength + ")";21:48
JanLeMannin the isID() check21:49
JanLeMannthis "fallback" causes the wrong sql type21:49
JanLeManneven if you add another check at the end, it will never be reached when chart isID=true21:49
CarlosRuizJanLeMann, how was the name of the column added?21:49
JanLeMannso you have to add another check inside the isID check21:49
JanLeMannfor chart21:49
JanLeMannbefore the last else21:49
JanLeManncarlos, not ending with _id21:50
CarlosRuizimages and charts must end with _ID in uppercase21:50
JanLeMannchart1_id, chart2_id, chart3_id.....21:50
nmicoudso, a beforeSave control is needed here ?21:50
JanLeMannwhy not just ad if(displaytype==chart)return number else21:51
JanLeMannbetween else if (fieldLength < 4) return "CHAR(" + fieldLength + ")"; else//EntityType, AD_Languagefallback return "VARCHAR2(" + fieldLength + ")";21:51
JanLeMann2 lines, simple fix. now chart columns can have any name21:51
JanLeMannuseful names21:51
JanLeMannsaleschart, orderchart or whatever21:52
CarlosRuizsure JanLeMann it sounds like an improvement - also for images21:52
JanLeManntheres even a FIXTHIS comment xD21:52
CarlosRuizbut anyways I usually recommend all foreign keys to end with _ID as a naming convention - including images and charts21:52
JanLeMannsure it's a good idea but especially new users will get confused when they try new stuff and it does not work because of naming conventions they might not know21:54
JanLeMannthe whole method looks like it could be improved a lot21:56
*** JanLeMann has quit IRC22:00
nmicoudhi CarlosRuiz. If you have time, could you have a look at https://idempiere.atlassian.net/browse/IDEMPIERE-2465. I wanted to create the patch but it seems more tricky and I'm not sure about the best way to achieve it. I'm wondering if an ugly hardcoded value could do the job22:24
*** nmicoud has quit IRC22:45
*** shmutalov has quit IRC22:47
CarlosRuiznorbertbede, BTW that has already an open ticket23:31
CarlosRuizhttps://idempiere.atlassian.net/browse/IDEMPIERE-136323:31
*** red1 has joined #idempiere23:36
*** ChanServ sets mode: +o red123:36

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!