| *** nmicoud has joined #idempiere | 06:25 | |
| *** a42niem has joined #idempiere | 06:40 | |
| *** CarlosRuiz has joined #idempiere | 07:14 | |
| nmicoud | Hello CarlosRuiz ; could you have a look at https://groups.google.com/forum/?nomobile=true#!topic/idempiere/wPcDrDvNWTM please ? I'm not sure if this is a bug or not :-/ | 07:23 |
|---|---|---|
| CarlosRuiz | Hi nmicoud | 07:24 |
| CarlosRuiz | checking | 07:24 |
| nmicoud | thanks | 07:24 |
| CarlosRuiz | seems like the variable is in days - as the name intends | 07:36 |
| CarlosRuiz | but the program was developed thinking in hours | 07:36 |
| nmicoud | so the * 24 should be removed, right ? | 07:37 |
| nmicoud | As it's an 'old' process, i fear to miss something | 07:37 |
| CarlosRuiz | the postgres part is also wrong | 07:39 |
| nmicoud | that's consistent :) | 07:39 |
| CarlosRuiz | :) not consistent - is wrong in another way :D | 07:39 |
| nmicoud | :D | 07:39 |
| CarlosRuiz | testing here | 07:39 |
| CarlosRuiz | if you have an interval of 4 days 11 hours 58 minutes | 07:40 |
| CarlosRuiz | the extract minutes returns 58 | 07:40 |
| CarlosRuiz | while the oracle version returns 6478 | 07:40 |
| CarlosRuiz | the sysconfig USER_LOCKING_MAX_ACCOUNT_LOCK_MINUTES is not explained | 07:43 |
| *** a_ has joined #idempiere | 07:43 | |
| nmicoud | AFAIR, is the time (in minute) where a user can't log after using wrong credentials | 07:44 |
| CarlosRuiz | so, if I set in 60 - I cannot unlock the user until 1 hour passed - right? | 07:44 |
| nmicoud | yes | 07:44 |
| CarlosRuiz | looking Login.java - getClients - line 1304 and below | 07:48 |
| CarlosRuiz | so - there is where the users are locked | 07:50 |
| CarlosRuiz | when trying to login | 07:50 |
| CarlosRuiz | this is my interpretation: | 07:50 |
| CarlosRuiz | suppose you set USER_LOCKING_MAX_INACTIVE_PERIOD_DAY = 7 | 07:50 |
| *** a_ has quit IRC | 07:50 | |
| CarlosRuiz | if you go to vacation for 10 days - your user is unlocked on your return | 07:51 |
| CarlosRuiz | but when you try to login the MAX_INACTIVE_PERIOD_DAY condition is reached and you are locked | 07:51 |
| nmicoud | right so you should not go on vacation :p or ask an admin to unlock you ? | 07:53 |
| *** checked has joined #idempiere | 07:54 | |
| nmicoud | in my case, it is set to 90 days | 07:55 |
| CarlosRuiz | then you call your administrator and he tries to unlock you but the process doesn't work because the program looks for hours (252) and compare with the days (10) | 07:55 |
| nmicoud | yep | 07:55 |
| checked | hi | 07:55 |
| nmicoud | in my case, a user locks its account with wrong password 3 times. it can be unlocked with process in the following hours. After a delay, this muse be done using sql | 07:56 |
| nmicoud | *must* | 07:56 |
| CarlosRuiz | Hi checked | 07:56 |
| CarlosRuiz | nmicoud, but I wonder something | 08:08 |
| CarlosRuiz | datelastlogin is not updated when the user fails to login | 08:08 |
| CarlosRuiz | so if we check for datelastlogin it won't work | 08:09 |
| *** checked has quit IRC | 08:09 | |
| nmicoud | why that ? | 08:10 |
| CarlosRuiz | I need to do some tests | 08:15 |
| CarlosRuiz | I have a suggested patch - do you want to try it in oracle? | 08:15 |
| CarlosRuiz | and I test in postgres | 08:15 |
| nmicoud | sure | 08:15 |
| CarlosRuiz | did you open a JIRA? | 08:15 |
| nmicoud | not yet, as i was not sure of the bug | 08:16 |
| CarlosRuiz | ok - can you please create one and I'll upload the suggested patch there | 08:17 |
| nmicoud | done | 08:17 |
| nmicoud | #3802 | 08:18 |
| RecordingBot | nmicoud: Error: "3802" is not a valid command. | 08:18 |
| CarlosRuiz | uploaded a patch there - but I want to do some tests before - I think the process is maybe broken | 08:21 |
| CarlosRuiz | let me try the test with the user on vacations | 08:21 |
| nmicoud | sure | 08:21 |
| nmicoud | Perhaps write on the ticket what test were / should be conducted. To be sure it's ok on both oracle & postgres ? | 08:22 |
| CarlosRuiz | ah the admin can unlock one by one - but the part not working is the no-user | 08:28 |
| nmicoud | yes, when a single user is selected, there is no control of period/days | 08:29 |
| nmicoud | which is correct as he should know what he's doing | 08:30 |
| CarlosRuiz | ok - so that seems ok - users in vacations are not unlocked by the general process (user empty) - but can be unlocked one by one | 08:33 |
| nmicoud | yes | 08:33 |
| nmicoud | so your patch is correct then ? | 08:34 |
| CarlosRuiz | yes - in postgres is working fine | 08:34 |
| CarlosRuiz | testing now the locked by wrong attempts | 08:35 |
| nmicoud | and is ok on oracle as that was what i tested yesterday | 08:35 |
| CarlosRuiz | ok - failed login attempts can be unlocked by the general reset locked with user empty | 08:37 |
| CarlosRuiz | now testing expired password | 08:37 |
| CarlosRuiz | ok - expired password doesn't lock the account - just force the change password panel | 08:44 |
| CarlosRuiz | so - if working in oracle I'll commit it | 08:44 |
| nmicoud | is working also (i made lots of tests un may/june) | 08:45 |
| CarlosRuiz | committed | 08:51 |
| nmicoud | thanks Carlos ; if you still have time, could you look at the #3801 ? (should be fast) | 08:51 |
| *** Not-5c22 has joined #idempiere | 09:05 | |
| Not-5c22 | [iDempiere5.1] jenkins built #209 completed (success) http://ci.idempiere.org/job/iDempiere5.1/209/ | 09:05 |
| Not-5c22 | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-5.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ | 09:07 |
| Not-5c22 | [iDempiere] nmicoud 356d53b - IDEMPIERE-3801 System user can't use saved queries | 09:07 |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3801 status set to "Resolved" -assignee set to "Nicolas Micoud" -resolution set to "Fixed" | 09:07 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3801 | 09:07 |
| nmicoud | thanks | 09:07 |
| CarlosRuiz | yw | 09:07 |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3800 status set to "Resolved" -assignee set to "Diego Ruiz" -resolution set to "Fixed" | 09:26 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3800 | 09:26 |
| Not-5c22 | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-5.1 [+0/-0/±2] https://bitbucket.org/idempiere/idempiere/commits/ | 09:26 |
| Not-5c22 | [iDempiere] druiz 82be836 - IDEMPIERE-3800 Improvements to CSV Export - fix and integrate improvements from Heng Sin | 09:26 |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2724 labels set to "Potential-Idea" | 09:30 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2724 | 09:30 |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2724 status set to "Resolved" -resolution set to "Incomplete" | 09:30 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2724 | 09:30 |
| Not-5c22 | [iDempiere5.1] jenkins built #210 completed (success) http://ci.idempiere.org/job/iDempiere5.1/210/ | 09:34 |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2725 status set to "Resolved" -resolution set to "Won't Fix" | 09:36 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2725 | 09:36 |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2733 labels set to "Potential-Idea" | 09:39 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2733 | 09:40 |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2733 status set to "Resolved" -resolution set to "Incomplete" | 09:40 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2733 | 09:40 |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2734 status set to "Resolved" -resolution set to "Duplicate" | 09:42 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2734 | 09:42 |
| *** Ayaz_ has joined #idempiere | 09:43 | |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2283 status set to "Resolved" -resolution set to "Fixed" | 09:45 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2283 | 09:45 |
| *** Ayaz_ has quit IRC | 09:56 | |
| Not-5c22 | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to default [+2/-0/±0] https://bitbucket.org/idempiere/idempiere/commits/ | 10:02 |
| Not-5c22 | [iDempiere] globalqss f049e62 - IDEMPIERE-2754 remove wrong test data. | 10:02 |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2754 Fix Version set to "5.1z" | 10:02 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2754 | 10:02 |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2754 status set to "Resolved" -assignee set to "Carlos Ruiz" -resolution set to "Fixed" | 10:02 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2754 | 10:02 |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2793 status set to "Resolved" -assignee set to "Deepak Pansheriya" -resolution set to "Fixed" | 10:33 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2793 | 10:33 |
| Not-5c22 | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to default [+0/-0/±30] https://bitbucket.org/idempiere/idempiere/commits/ | 10:33 |
| Not-5c22 | [iDempiere] globalqss 5d80a8c - IDEMPIERE-2793 Extendability improvements / integrate patch from logilite (Deepak) - Changed private access modifier of members to 'Protected' | 10:33 |
| Not-5c22 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2793 Fix Version set to "5.1z" | 10:33 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2793 | 10:33 |
| Not-5c22 | [iDempiere-mvn] jenkins built #41 completed (success) http://ci.idempiere.org/job/iDempiere-mvn/41/ | 10:34 |
| Not-5c22 | [iDempiere-mvn] jenkins built #42 completed (success) http://ci.idempiere.org/job/iDempiere-mvn/42/ | 11:03 |
| *** nmicoud_ has joined #idempiere | 12:25 | |
| *** nmicoud has quit IRC | 12:29 | |
| Not-5c22 | [IDEMPIERE] hieplq updated IDEMPIERE-2610 status set to "Closed" -resolution set to "Fixed" | 13:15 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2610 | 13:15 |
| Not-5c22 | [IDEMPIERE] hieplq updated IDEMPIERE-3687 status set to "Closed" -resolution set to "Fixed" | 13:17 |
| Not-5c22 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3687 | 13:17 |
| *** xapiens has quit IRC | 13:52 | |
| *** asim has joined #idempiere | 14:18 | |
| asim | hello | 14:18 |
| asim | is any body here>????? | 14:19 |
| *** asim has quit IRC | 14:20 | |
| *** nmicoud_ has quit IRC | 15:11 | |
| *** xapiens has joined #idempiere | 15:39 | |
| *** CarlosRuiz has quit IRC | 15:50 | |
| *** a42niem has quit IRC | 23:32 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!